Experimental new docker system that will work with volume_mounts #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlad
changed the base branch from
master
to
feature/test-experimental-docker-with-volume-mounts
wlad
changed the base branch from
feature/test-experimental-docker-with-volume-mounts
to
master
|
@PaulGWebster thank you for this PR. If everything works out well I'd like some other colleges to review mentioned security implications. |
wlad
added a commit
to ehrbase/ehrbase
that referenced
this pull request
Mar 17, 2021
as suggested by PR ehrbase/docker#3
wlad
added a commit
to ehrbase/ehrbase
that referenced
this pull request
Mar 17, 2021
…by Docker Hub [skip-ci] - to adapt changes suggested in PR ehrbase/docker#3
wlad
suggested changes
Mar 17, 2021
|
|
||
| # Stop database before proceeding | ||
| su - postgres -c "pg_ctl -D ${PGDATA} -w stop" | ||
| psql -U "${POSTGRES_USER}" -d "${POSTGRES_DB}" <<-EOSQL |
There was a problem hiding this comment.
please use verbose form of cli options --username and --dbname
| @@ -3,56 +3,65 @@ FROM postgres:11.5-alpine | |||
| # Set default values for database user and passwords | |||
| ARG EHRBASE_USER="ehrbase" | |||
| ARG EHRBASE_PASSWORD="ehrbase" | |||
| ENV EHRBASE_USER=${EHRBASE_USER} | |||
| ENV EHRBASE_PASSWORD=${EHRBASE_PASSWORD} | |||
| ENV EHRBASE_USER=${EHRBASE_USER:-ehrbase} | |||
There was a problem hiding this comment.
what is this change good for?
I see one test suite failing and I guess this change may be the reason(?)
wlad
added a commit
that referenced
this pull request
Mar 22, 2021
to create and push experimental docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are security implications to this!
Make sure to see how the /script directory works!
Also I had to change to MD5 in the pg_hba.conf though I imagine someone with more postgres experience could resolve that!