Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup project structure #5

Merged
merged 19 commits into from
May 14, 2024
Merged

Conversation

jmg-duarte
Copy link
Collaborator

@jmg-duarte jmg-duarte commented May 8, 2024

Setup the project structure according to the guidelines, namely:

Points to a polkadot-sdk fork due to paritytech/polkadot-sdk#4344 Fixed by pinning the working version.

Fixes #1

@serg-temchenko serg-temchenko added the ready for review Review is needed label May 8, 2024
@serg-temchenko serg-temchenko linked an issue May 8, 2024 that may be closed by this pull request
Copy link
Contributor

@serg-temchenko serg-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, are the implementations from the node and runtime folders simply reflections of the template code, or have there been adjustments and changes made beyond the .toml files?

  1. Could you please reorganize all indents from hard tabs to spaces?
  2. I noticed that we already have a .gitignore file in the main branch. However, I have some questions about it, particularly regarding whether it was taken from some convention definition. Why does it contain many random entries like.AppleDB etc? For example, here is the default .gitignore for Rust projects, and here is one from substrate. My point is simply to add code with an understanding of its requirements.
  3. I notice that we have a .lock file in the gitignore, and I strongly believe that this file should be under version control rather than ignored. This ensures a stable build, as an example, situation you experienced with this task and forks and substrate dependency, which has issues when using the master branch...
  4. Also, please try to fix that issue with build by overwrite that libp2p dependency version. I believe this might help.

node/Cargo.toml Outdated Show resolved Hide resolved
node/Cargo.toml Outdated Show resolved Hide resolved
runtime/Cargo.toml Outdated Show resolved Hide resolved
runtime/Cargo.toml Outdated Show resolved Hide resolved
node/Cargo.toml Outdated Show resolved Hide resolved
node/Cargo.toml Outdated Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@serg-temchenko serg-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you @jmg-duarte for resolving comments and fixing the problem with indirect dependencies. Great job! 🔥 One small comment and we are good to go!

Also, please update the description and remove any mention of the fork to avoid confusing people in the future. I've updated it. Please feel free to change it if you have other preferences for how to highlight this.

Cargo.toml Show resolved Hide resolved
@serg-temchenko serg-temchenko mentioned this pull request May 14, 2024
polkadot-launch/config.json Show resolved Hide resolved
runtime/src/apis.rs Show resolved Hide resolved
runtime/src/benchmarks.rs Show resolved Hide resolved
runtime/src/configs/mod.rs Show resolved Hide resolved
@serg-temchenko serg-temchenko merged commit 7fded56 into develop May 14, 2024
@serg-temchenko serg-temchenko deleted the feat/1/project-setup branch May 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project setup
3 participants