-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup project structure #5
Conversation
Using a fork due to paritytech/polkadot-sdk#4344 not being integrated in v1.11.0 yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, are the implementations from the node
and runtime
folders simply reflections of the template code, or have there been adjustments and changes made beyond the .toml
files?
- Could you please reorganize all indents from hard tabs to spaces?
- I noticed that we already have a
.gitignore
file in the main branch. However, I have some questions about it, particularly regarding whether it was taken from some convention definition. Why does it contain many random entries like.AppleDB
etc? For example, here is the default .gitignore for Rust projects, and here is one from substrate. My point is simply to add code with an understanding of its requirements. - I notice that we have a .lock file in the gitignore, and I strongly believe that this file should be under version control rather than ignored. This ensures a stable build, as an example, situation you experienced with this task and forks and substrate dependency, which has issues when using the master branch...
- Also, please try to fix that issue with build by overwrite that libp2p dependency version. I believe this might help.
The original polkadot-sdk was built pointing litep2p to master at the time of the build, master was version 0.3.0, commit b142c9eb611fb2fe78d2830266a3675b37299ceb, this patch is required since the dependency points to master and not the version/hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you @jmg-duarte for resolving comments and fixing the problem with indirect dependencies. Great job! 🔥 One small comment and we are good to go!
Also, please update the description and remove any mention of the fork to avoid confusing people in the future. I've updated it. Please feel free to change it if you have other preferences for how to highlight this.
Setup the project structure according to the guidelines, namely:
Points to a polkadot-sdk fork due to paritytech/polkadot-sdk#4344Fixed by pinning the working version.Fixes #1