allow filepath version < 1.6 #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unable to test this at the moment, since |
|
@RyanGlScott a new hashable is now out with filepath-1.5 support: https://hackage.haskell.org/package/hashable-1.4.4.0/changelog |
|
Great! However, since I've last viewed this, the changes from #1060 have been folded into this PR. This feels odd, as #1060 doesn't really have anything to do with the stated purpose of this PR. @BebeSparkelSparkel, can you revert the #1060-related changes so that we can handle them separately? |
|
Superseded by #1064. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new major version of filepath 1.5.0.0.
Tested and seemed to build fine.