Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow filepath version < 1.6, rebased #1064

Merged
merged 1 commit into from
Apr 5, 2024
Merged

allow filepath version < 1.6, rebased #1064

merged 1 commit into from
Apr 5, 2024

Conversation

ysangkok
Copy link

@ysangkok ysangkok commented Apr 5, 2024

This is #1054 but without the mtl-related changes. I also rebased this and ran the test suite using cabal test -c 'filepath>=1.5'.

RyanGlScott
RyanGlScott approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RyanGlScott RyanGlScott merged commit 0052a37 into ekmett:master Apr 5, 2024
11 checks passed
@RyanGlScott
Copy link
Collaborator

I've applied this as a Hackage revision.

@RyanGlScott RyanGlScott mentioned this pull request Apr 5, 2024
Closed
@ysangkok ysangkok deleted the new-filepath branch April 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysangkok @RyanGlScott @BebeSparkelSparkel