[headerLinks] horizontally center mobileList button #8122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, folks! 👋🏻
As part of Papercuts project, I've been working on the [Dashboard] Center Save top nav button for small viewport Kibana issue. While working on this, I noticed that in the HeaderLinks pop-up on mobile, the
Save
button is left-aligned in different areas across Kibana.For example, in Analytics Dashboards:
This made me think that perhaps we could make the button span the entire width of the modal, like so:
What do you think? I'd love to hear your thoughts, as it's possible this is intentional and designed to be this way. 😁
In this PR, I am sharing the lines of code I added as a reference, but there may be other ways to implement this.
General checklist