[Dashboard] Center Save top nav button for small viewport
#180093
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Dashboard
Dashboard related features
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Project:Dashboard Usability
Related to the Dashboard Usability initiative
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
cqliu1
added
bug
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
Just FYI - this was intentional if I recall correctly! Not saying that this was necessarily the correct decision, but I believe we were trying to discourage editing dashboards on such a small screen, since the experience isn't... great. Not saying that is the right call necessarily, but I wouldn't personally consider this a bug. |
cqliu1
added
impact:low
|
That's fair. No one should be editing dashboards on such a small device. Maybe we just leave the |
cqliu1
changed the title
Save top nav button for small viewport
|
Seems that the button centering is related to the Eui component, so I opened a PR in EUI repository, and will wait for their feedback. |
paulinashakirova
added a commit
that referenced
this issue
Nov 20, 2024
## Summary This PR solves [[Dashboard] Center Save top nav button for small viewport](#180093 (comment)) issue.   The change only affects the mobile menu.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 20, 2024
…c#200823) ## Summary This PR solves [[Dashboard] Center Save top nav button for small viewport](elastic#180093 (comment)) issue.   The change only affects the mobile menu. (cherry picked from commit 971c1f3)
kibanamachine
added a commit
that referenced
this issue
Nov 20, 2024
…200823) (#200927) # Backport This will backport the following commits from `main` to `8.x`: - [fix: make panel top nav menu item button full width on mobile (#200823)](#200823) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T13:56:41Z","message":"fix: make panel top nav menu item button full width on mobile (#200823)\n\n## Summary\r\n\r\nThis PR solves [[Dashboard] Center Save top nav button for small\r\nviewport](#180093 (comment)) issue.\r\n\r\n\r\n\r\n\r\n\r\nThe change only affects the mobile menu.","sha":"971c1f3c350cd36c6e21441deb5b473f839963cd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-minor","papercut","v8.17.0"],"title":"fix: make panel top nav menu item button full width on mobile","number":200823,"url":"https://github.com/elastic/kibana/pull/200823","mergeCommit":{"message":"fix: make panel top nav menu item button full width on mobile (#200823)\n\n## Summary\r\n\r\nThis PR solves [[Dashboard] Center Save top nav button for small\r\nviewport](#180093 (comment)) issue.\r\n\r\n\r\n\r\n\r\n\r\nThe change only affects the mobile menu.","sha":"971c1f3c350cd36c6e21441deb5b473f839963cd"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200823","number":200823,"mergeCommit":{"message":"fix: make panel top nav menu item button full width on mobile (#200823)\n\n## Summary\r\n\r\nThis PR solves [[Dashboard] Center Save top nav button for small\r\nviewport](#180093 (comment)) issue.\r\n\r\n\r\n\r\n\r\n\r\nThe change only affects the mobile menu.","sha":"971c1f3c350cd36c6e21441deb5b473f839963cd"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
paulinashakirova
added a commit
to paulinashakirova/kibana
that referenced
this issue
Nov 26, 2024
…c#200823) ## Summary This PR solves [[Dashboard] Center Save top nav button for small viewport](elastic#180093 (comment)) issue.   The change only affects the mobile menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version:
8.11.0+
The
Editbutton is missing from this condensed top nav menu for viewports narrower than 768px. It should look similar to theSaveprimary button inI also noticed the
Savebutton in this menu while in edit mode has a gap on the right side. It should be full width in this popover.The text was updated successfully, but these errors were encountered: