Run BK exhaustive pipeline when code is pushed #15738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are close to sunsetting Jenkins by completing the exhaustive tests Buildkite pipeline, it makes sense to start already running the exhisting phases (testing and compatibility). This commit defines the trigger to be code events, i.e. direct pushes and merge commits, similar to what we currently have in Jenkins.
dliappis
commented
Jan 2, 2024
dliappis
commented
Jan 2, 2024
| build_branches: true | ||
| build_pull_request_forks: false | ||
| build_pull_requests: false | ||
| build_tags: false |
There was a problem hiding this comment.
conversely, I felt that we don't need to trigger this pipeline when we push tags.
dliappis
commented
Jan 2, 2024
|
@elasticmachine run elasticsearch-ci/docs |
dliappis
force-pushed
the
trigger-exhaustive-tests
branch
3 times, most recently
from
bec791a to
9204c09
Compare
dliappis
force-pushed
the
trigger-exhaustive-tests
branch
from
9204c09 to
6a2f84f
Compare
|
@jsvd I addressed your comment (about skipping on docs changes). This is an example (manually triggered) build: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/56 Regarding the other comments we are aligned and no further changes are needed. Please take another look when you can. |
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @dliappis |
|
@logstashmachine backport 8.12 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
This commit enables running the exhaustive tests Buildkite pipeline (i.e. the equivalent to the `main` Jenkins tests) ; the trigger is code events, i.e. direct pushes, merge commits and creation of new branches. CI is skipped if changes are only related to files under `docs/`. (cherry picked from commit c8726b7)
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 10, 2024
This commit enables running the exhaustive tests Buildkite pipeline (i.e. the equivalent to the `main` Jenkins tests) ; the trigger is code events, i.e. direct pushes, merge commits and creation of new branches. CI is skipped if changes are only related to files under `docs/`.
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 10, 2024
This commit enables running the exhaustive tests Buildkite pipeline (i.e. the equivalent to the `main` Jenkins tests) ; the trigger is code events, i.e. direct pushes, merge commits and creation of new branches. CI is skipped if changes are only related to files under `docs/`.
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 10, 2024
This commit enables running the exhaustive tests Buildkite pipeline (i.e. the equivalent to the `main` Jenkins tests) ; the trigger is code events, i.e. direct pushes, merge commits and creation of new branches. CI is skipped if changes are only related to files under `docs/`.
dliappis
added a commit
that referenced
this pull request
Jan 10, 2024
This commit enables running the exhaustive tests Buildkite pipeline (i.e. the equivalent to the `main` Jenkins tests) ; the trigger is code events, i.e. direct pushes, merge commits and creation of new branches. CI is skipped if changes are only related to files under `docs/`.
dliappis
added a commit
that referenced
this pull request
Jan 10, 2024
This commit enables running the exhaustive tests Buildkite pipeline (i.e. the equivalent to the `main` Jenkins tests) ; the trigger is code events, i.e. direct pushes, merge commits and creation of new branches. CI is skipped if changes are only related to files under `docs/`. (cherry picked from commit c8726b7) Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis
added a commit
that referenced
this pull request
Jan 10, 2024
This commit enables running the exhaustive tests Buildkite pipeline (i.e. the equivalent to the `main` Jenkins tests) ; the trigger is code events, i.e. direct pushes, merge commits and creation of new branches. CI is skipped if changes are only related to files under `docs/`. (cherry picked from commit c8726b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
As we are close to sunsetting Jenkins by completing the exhaustive tests Buildkite pipeline, it makes sense to start already running the existing phases (testing and compatibility).
This commit defines the trigger to be code events, i.e. direct pushes and merge commits, similar to what we currently have in Jenkins.
Why is it important/What is the impact to the user?
It allows us to gradually remove the corresponding phases from Jenkins to reduce CI duplication.
This will be especially useful when merging #15696 as the change is incompatible with Jenkins.
How to test this PR locally
An example build triggered manually can be found in https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/49#_
Unfortunately Windows tests will fail due to #15562
Related issues