Bump node to supported versions #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Feb 8, 2023
See [Node Releases](https://github.com/nodejs/release#release-schedule)
hjdivad
force-pushed
the
hjdivad/bump-node
branch
from
7b727fd
to
710739c
Compare
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 17 17
Lines 550 550
=======================================
Hits 519 519
Misses 31 31 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@SergeAstapov This makes sense to me. This PR is only cut in a pre-release, so having 3.0.0 proper only support node 16 sounds right. Do you have cycles to post a PR? I'd be happy to review if you do. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Node Releases
Floating deps test is currently failing with things like
Which is to be expected for out-of-support node versions.