-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Node.js 14 support #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look into the failing tests
As in #913 the floating deps test is expected to fail, but the rest should be green.
@hjdivad it seems never version of npm bundled with Node.js 16 cause a hard error because it seems more correctly to actually publish that version to npm, wonder if @kategengler can do so. meanwhile I'll try to look if there is something else missing or I can came up with a workaround |
Hey folks 👋 #893 has CI passing and works around that problem you also identified @SergeAstapov |
7d737aa
to
cdabdf5
Compare
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 94.54% 94.59% +0.04%
==========================================
Files 17 17
Lines 550 555 +5
==========================================
+ Hits 520 525 +5
Misses 30 30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8d7009f
to
80d774a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested from @mansona
Thank you!! |
Follow up to #913