Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor VR Harp addresses #99

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Refactor VR Harp addresses #99

merged 4 commits into from
Nov 5, 2024

Conversation

aspaNeuro
Copy link
Contributor

@aspaNeuro aspaNeuro commented Oct 28, 2024

This PR change the address space for VR sensors:

  • VRTransform from 219 to 180
  • GeoReference 211 to 181
  • ScreenCapture 220 to 182
  • VR Experiment protocol [225-228] to [185-188]
  • Glia [215-218] to [190-193]
  • Update Readme

Fix #95

aspaNeuro and others added 2 commits October 28, 2024 00:40
- VRTransform from 219 to1 180
- GeoReference 211 to 181
- ScreenCapture 220 to 182
- VR Experiment protocol [225-228] to [185-188]
- Glia [215-218] to [190-193]
- Update Readme.cm

Co-authored-by: jfrazao <[email protected]>
@aspaNeuro aspaNeuro added feature New planned feature fix Pull request that fixes an issue labels Oct 28, 2024
@aspaNeuro aspaNeuro added this to the Indoor Experiments - VR milestone Oct 28, 2024
README.md Outdated Show resolved Hide resolved
@glopesdev
Copy link
Member

@aspaNeuro one last comment regarding the protocol addresses:

VR Experiment protocol [225-228] to [185-188]

These seem to have been renamed but are not included in the main README file. This could potentially make sense since they are protocol specific addresses, but should we then include them in an experiment-specific README somewhere in the repo?

@aspaNeuro
Copy link
Contributor Author

@aspaNeuro one last comment regarding the protocol addresses:

VR Experiment protocol [225-228] to [185-188]

These seem to have been renamed but are not included in the main README file. This could potentially make sense since they are protocol specific addresses, but should we then include them in an experiment-specific README somewhere in the repo?

They are in the main README I think.

Are you saying to copy these as well to the https://github.com/emotional-cities/pluma-experiments/blob/main/VR-Alfama/README.md, I dont think this is relevant information for you to setup the VR.

The experimental protocol itself has some LSL messages that need documentation, I'm currently waiting for feedback from João Amaro on this and created an issue #96 for dealing with these.

@aspaNeuro
Copy link
Contributor Author

@aspaNeuro one last comment regarding the protocol addresses:

VR Experiment protocol [225-228] to [185-188]

These seem to have been renamed but are not included in the main README file. This could potentially make sense since they are protocol specific addresses, but should we then include them in an experiment-specific README somewhere in the repo?

They are in the main README I think.

Are you saying to copy these as well to the https://github.com/emotional-cities/pluma-experiments/blob/main/VR-Alfama/README.md, I dont think this is relevant information for you to setup the VR.

The experimental protocol itself has some LSL messages that need documentation, I'm currently waiting for feedback from João Amaro on this and created an issue #96 for dealing with these.

The commit cd9bfc8 fix this problem

@glopesdev glopesdev changed the title Refactor VR Harp adresses Refactor VR Harp addresses Nov 5, 2024
@glopesdev glopesdev merged commit 16dd1aa into main Nov 5, 2024
@glopesdev glopesdev deleted the harp-adresses branch November 5, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature fix Pull request that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clashes in register addresses between outdoor and VR data schemas
3 participants