Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull translations from Transifex #312

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Pull translations from Transifex #312

merged 1 commit into from
Nov 6, 2024

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Nov 6, 2024

Run tx pull --use-git-timestamps. This brings a Spanish translation made by myself, and a partial German translation that's being contributed.

@manuq manuq requested a review from dbnicholson November 6, 2024 19:20
Run `tx pull --use-git-timestamps`. This brings a Spanish translation
made by myself, and a partial German translation that's being
contributed. I only added the Spanish one for now.
@manuq manuq force-pushed the pull-translations branch from 8e3351a to 9da4dc3 Compare November 6, 2024 19:34
@dbnicholson
Copy link
Member

What happened to the German translation?

@manuq
Copy link
Contributor Author

manuq commented Nov 6, 2024

Update: I removed the partial DE translation as it's changing things between {} like "group" or "STRING", so it won't work:

"ist in Gruppe {Gruppe: ZEICHENKETTE}"

Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In the future, we might have Transifex post these PRs. For a human maintainer like you, I feel like you can just push these directly if you've reviewed them.

@dbnicholson dbnicholson merged commit 1a30ffd into main Nov 6, 2024
3 checks passed
@dbnicholson dbnicholson deleted the pull-translations branch November 6, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants