This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
testcontainers setup #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
=============================================
+ Coverage 53.08% 65.43% +12.34%
- Complexity 11 15 +4
=============================================
Files 7 7
Lines 81 81
Branches 1 1
=============================================
+ Hits 43 53 +10
+ Misses 38 28 -10 ☔ View full report in Codecov by Sentry. |
|
@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
Merged
|
@l3r8yJ WDYT? |
|
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Oops, I failed. You can see the full log here (spent 2min) |
|
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
|
@h1alexbel I'm not sure if we can merge this pr with #43, because that one doesn't work on my mac either |
@h1alexbel Oops, I failed. You can see the full log here (spent 2min) |
|
@l3r8yJ need to deep dive into SHA256 algorithm then |
|
@l3r8yJ rultor reads config from the master branch, where the build is running with ITs; |
|
@h1alexbel i think it is gonna be ok after i close #43 |
|
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Oops, I failed. You can see the full log here (spent 2min) |
|
@h1alexbel you need to add |
|
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 2min) |
|
@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26
@l3r8yJ take a look, please
PR-Codex overview
This PR focuses on improving the Maven build process and adding integration tests for the Cassandra session.
Detailed summary