Merge pull request #26 from ericktijerou/bugfix/framelayout

Fix skeleton - Cardview/FrameLayout
ericktijerou · Jan 24, 2021 · f6bf2e8 · f6bf2e8
2 parents 8bc9472 + d4472b0
commit f6bf2e8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -23,7 +23,7 @@ You can [download](https://bintray.com/ericktijerou/maven/koleton/_latestVersion
 ```gradle
 // In your module's `build.gradle.kts`
 dependencies {
-    implementation("com.ericktijerou.koleton:koleton:0.8.1")
+    implementation("com.ericktijerou.koleton:koleton:0.8.2")
 }
 ```
 

diff --git a/gradle.properties b/gradle.properties
@@ -27,4 +27,4 @@ compileSdk=29
 groupId=com.ericktijerou.koleton
 vcsUrl=https://github.com/ericktijerou/koleton
 issueTrackerUrl=https://github.com/ericktijerou/koleton/issues
-publishVersion=0.8.1
+publishVersion=0.8.2
diff --git a/koleton-base/src/main/kotlin/koleton/util/Views.kt b/koleton-base/src/main/kotlin/koleton/util/Views.kt
@@ -1,5 +1,6 @@
 package koleton.util
 
+import android.graphics.Color
 import android.os.Build
 import android.view.View
 import android.view.ViewGroup
@@ -47,6 +48,7 @@ internal fun ViewGroup.children(): List<View> {
 internal fun View.generateSimpleKoletonView(attributes: Attributes): SimpleKoletonView {
     val parent = parent as? ViewGroup
     return SimpleKoletonView(context).also {
+        validateBackground()
         it.id = id
         it.layoutParams = layoutParams
         it.cloneTranslations(this)
@@ -58,6 +60,10 @@ internal fun View.generateSimpleKoletonView(attributes: Attributes): SimpleKolet
     }
 }
 
+internal fun View.validateBackground() {
+    if (this is FrameLayout) setBackgroundColor(Color.TRANSPARENT)
+}
+
 internal fun RecyclerView.generateRecyclerKoletonView(attributes: RecyclerViewAttributes): RecyclerKoletonView {
     val parent = parent as? ViewGroup
     return RecyclerKoletonView(context).also {