control-plane: fix deletion of old drafts #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the migration for deleting old drafts, so that it can be applied. It was broken, and was thankfully never applied in production.
psFried
force-pushed
the
phil/delete-drafts-fix
branch
2 times, most recently
from
f25d6c8 to
e5e79c1
Compare
psFried
force-pushed
the
phil/delete-drafts-fix
branch
from
e5e79c1 to
bb8c4c3
Compare
Upgrades the `delete_old_drafts` function to `delete_old_rows`, because it's now our one-stop-shop for daily cleanup. This adds deletion of old `internal.log_lines` and `catalog_stats_hourly`, which would otherwise accumulate indefinitely. This also reduces the retention window of drafts to 10 days, since that is what's been used when cleaning them up manually.
psFried
force-pushed
the
phil/delete-drafts-fix
branch
from
bb8c4c3 to
dd0b0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the migration for deleting old drafts, so that it can be applied. It was broken, and was thankfully never applied in production.
This change is