Release in-flight frames when the send fails #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can differentiate between a frame that is currently being sent (or failed to send completely) and a frame sent over the network.
Not great but I'm tired :(
Cleaner/faster code by not requiring a condition.
jamwaffles
force-pushed
the
release-frames-on-error
branch
from
8f5a76c
to
f009e32
Compare
jamwaffles
force-pushed
the
release-frames-on-error
branch
2 times, most recently
from
5909dd0
to
407f13c
Compare
jamwaffles
force-pushed
the
release-frames-on-error
branch
from
407f13c
to
31cd584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow frame send retry attempts so EtherCrab is more resilient against temporary (within
Timeouts::pdu) network outages.