Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7503: Move to Draft #9080

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Update EIP-7503: Move to Draft #9080

merged 3 commits into from
Dec 19, 2024

Conversation

0xwormhole
Copy link
Contributor

@0xwormhole 0xwormhole commented Dec 2, 2024

The changes proposed to EIP-7503 are as follows. I have omitted the cryptographic details, as I lack expertise in that field. However, my changes are meant to provide the Ethereum developer with a basic structure that they should consider when working on the full implementation.

🪱🕳️

@0xwormhole 0xwormhole requested a review from eth-bot as a code owner December 2, 2024 22:29
@github-actions github-actions bot added c-status Changes a proposal's status s-draft This EIP is a Draft t-core labels Dec 2, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 2, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Dec 2, 2024
@eth-bot eth-bot changed the title Update eip-7503.md Update EIP-7503: Move to Draft Dec 2, 2024
@irnb
Copy link

irnb commented Dec 3, 2024

@0xwormhole Thank you for your contribution !
I need some time to review and go through the suggestions you’ve provided. I’ll submit my review within three days.

Copy link
Contributor

@keyvank keyvank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool, thanks!

@keyvank
Copy link
Contributor

keyvank commented Dec 3, 2024

I'm not very familiar with Privacy Pools protocol. Who will maintain the privacy-pool root in that case?

@irnb
Copy link

irnb commented Dec 3, 2024

@keyvank

https://papers.ssrn.com/sol3/papers.cfm?abstract_id=4563364

I think it's something handled in offchain, people could provide it to prove they are not part specific mint transactions or etc (non inclusion proof)

@0xwormhole
Please correct me if I’m mistaken.

Signed-off-by: 0xwormhole <>
@0xwormhole
Copy link
Contributor Author

@irnb @keyvank I added a reference to the EIP. Companies like 0xbow can maintain these roots, also there have been historically created lists of "known bad events" by ethereum ecosystem security teams, and we can use automated mechanisms to exclude coins related to these incidents.

This mechanism is entirely voluntary; a withdrawer could always create and use a "universal root" that includes all historical transactions. However, the goal of explicitly including the privacy pool root feature is to make it nearly cost-free for users to adopt a root that excludes hacks and other coins that they want to refuse to associate with. This is a show of good faith of the ecosystem's commitment to not supporting behavior universally considered criminal, and gives users tools to satisfy local compliance needs like convincing exchanges that their source of funds is not suspicious.

@keyvank
Copy link
Contributor

keyvank commented Dec 5, 2024

@0xwormhole I like it! Let's have it.

g11tech
g11tech previously approved these changes Dec 17, 2024
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since approced by @keyvank one of the authors

@0xwormhole
Copy link
Contributor Author

@g11tech @eth-bot when running the GitHub workflow for this pull request, an issue is occurring. If there's anything wrong, could you investigate? It would be great if you could merge this pull request. Thank you!

Copy link

The commit df3fbe3 (as a parent of 97a2fc2) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 19, 2024
@eth-bot eth-bot enabled auto-merge (squash) December 19, 2024 18:40
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 57d8598 into ethereum:master Dec 19, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status s-draft This EIP is a Draft t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants