Update EIP-7503: Move to Draft

EIPS/eip-7503.md

@@ -2,12 +2,13 @@
 eip: 7503
 title: Zero-Knowledge Wormholes
 description: Enable minting of secretly burnt Ethers as a native privacy solution for Ethereum
-author: Keyvan Kambakhsh (@keyvank), Hamid Bateni (@irnb), Amir Kahoori <[email protected]>, Nobitex Labs <[email protected]>
+author: Keyvan Kambakhsh (@keyvank), Hamid Bateni (@irnb), Amir Kahoori <[email protected]>, Nobitex Labs <[email protected]>, 0xwormhole (@0xwormhole)
 discussions-to: https://ethereum-magicians.org/t/eip-7503-zero-knowledge-wormholes-private-proof-of-burn-ppob/15456
-status: Stagnant
+status: Draft
 type: Standards Track
 category: Core
 created: 2023-08-14
+requires: 2718, 4844, 7708
 ---
 
 ## Abstract
@@ -25,6 +26,60 @@ all of the Ethereum accounts with zero outgoing transactions by default.
 
 ## Specification
 
+### Parameters
+
+* `MAGIC_ADDRESS`: `0xfe` (one byte)
+* `MAGIC_NULLIFIER`: `0x01` (one byte)
+* `MAGIC_POW`: `0x02` (one byte)
+* `MAGIC_CHANGE`: `0x0404040404040404040404040404040404040404040404040404040404040404`
+* `POW_LOG_DIFFICULTY`: `24`
+* `MAX_DEPOSIT`: `32 * 10**18` wei
+* `WormholeTxType`: `TBD`
+* `WORMHOLE_NULLIFIER_ADDRESS`: `TBD`
+* `RECEIPT_PREFIX`: `TBD` (datatype `List[bool]`)
+
+- - - 
+
+We define a new [EIP-2718](./eip-2718.md) transaction type, where `TransactionType` is `WormholeTxType` and the `TransactionPayload` format is as follows:
+
+`[chain_id, nonce, max_priority_fee_per_gas, max_fee_per_gas, gas_limit, to, data, access_list, root_beacon_block_number, proof]`
+
+Verifying this type of transaction requires confirming that:
+
+1. The proof is a zero-knowledge proof:
+    * Private inputs: `secret`, `main_index`, `main_branch`, `privacy_pool_index`, `privacy_pool_branch`, `deposit_value`, `deposit_sender`, `change_value_salt`, `change_value`
+    * Public inputs: `beacon_block_root`, `nullifier`, `privacy_pool_root`, `withdraw_value`, `change_value_hash`
+    * Function: verify all of the following conditions
+        * `verify_merkle_branch(root=beacon_block_root, index=RECEIPT_PREFIX + main_index, leaf=make_receipt_hash(deposit_sender, deposit_value, change_value_salt, secret), branch=main_branch)`
+        * `verify_merkle_branch(root=privacy_pool_root, index=privacy_pool_index, leaf=make_receipt_hash(deposit_sender, deposit_value, change_value_salt, secret), branch=privacy_pool_branch)`
+        * `nullifier=sha256(MAGIC_NULLIFIER + secret)`
+        * `sha256(MAGIC_POW + secret) % 2**POW_LOG_DIFFICULTY == 0`
+        * `change_value_salt = sha256(change_value_salt, change_value)`
+        * `change_value + withdraw_value = deposit_value` (all values are unsigned int, also need to confirm that there is no overflow)
+        * `deposit_value <= MAX_DEPOSIT`
+2. `SLOAD(WORMHOLE_NULLIFIER_ADDRESS, proof.nullifier) = 0`
+3. `get_beacon_block_root(root_beacon_block_number) == proof.beacon_block_root`
+
+We define `make_receipt_hash` as follows:
+
+```
+def make_receipt_hash(deposit_sender: Address, value: uint256, change_value_salt: bytes32, secret: bytes32):
+    if deposit_sender != 0:
+        to_address = sha256(MAGIC_ADDRESS + secret)[12:]
+        topics = [MAGIC_EIP_7708, deposit_sender, to_address]
+        logdata = int_to_bytes32(value)
+    else:
+        topics = [MAGIC_CHANGE, hash(change_value_salt, value)]
+        logdata = bytes([])
+    return get_ssz_root_hash(Log(topics=topics, data=logdata))
+```
+
+The hash of the transaction (excluding proof) should be included in the randomness for generating the zero-knowledge proof. This ensures the proof serves as a signature.
+
+If the transaction is confirmed, generate `proof.withdraw_value` ether at address `WORMHOLE_NULLIFIER_ADDRESS`. Then proceed with a normal call from this address using that value. Before the call, set `SSTORE(WORMHOLE_NULLIFIER_ADDRESS, proof.nullifier, 1)`, and emit a log event where `topics = [MAGIC_CHANGE, proof.change_value_hash]` and `logdata = bytes([])`.
+
+## Rationale 
+
 In Elliptic-Curve based digital signatures, normally there is a secret scalar $s$, from which 
 a public-key is calculated (By multiplying the generator point with the scalar: $s \times G$). An 
 Ethereum EOA-address is the keccak hash of a public-key.
@@ -54,10 +109,7 @@ that an Ethereum accounts exists in the state-root, which holds some amount of E
 By revealing this to the Ethereum blockchain and providing something like a nullifier 
 (E.g. $h(s | 123)$ so that double minting of same burnt tokens are not possible), we can add a new 
 ***minting*** functionality for ETH so that people can migrate their secretly burnt tokens to a 
-completely new address, without any trace on the blockchain. The target addresses can also be burn 
-addresses, keeping the re-minted funds in the anonymity pool.
-
-## Rationale
+completely new address, without any trace on the blockchain. 
 
 Cryptocurrency mixers like TornadoCash can successfully obfuscate Ethereum transactions, but it's
 easy for the governments to ban usage of them. Anybody who has interactions with a mixer contract,
@@ -71,8 +123,17 @@ the set of all Secp256k1 points $E(K)$ into two subsets/address-spaces:
 
 The spendable/unspendable addresses are not distinguishable, so we can exploit this fact and define
 a spendability rule for the money sent to addresses that can't be spent using regular elliptic-curve
-signatures. Using the help of Zero-Knowledge proofs, we can hide the transaction trace and design 
-a new privacy protocol, which is what this EIP is proposing.
+signatures. 
+
+Deposits are made by sending ether to an address `sha256(MAGIC_ADDRESS + secret)[12:]`, where you know the `secret`. This ensures that no one knows about the deposit unless you reveal it: a deposit onchain is not distinguishable from sending ether to a friend. Withdrawals use a zero-knowledge proof to prove knowledge of a previous deposit's `secret`.
+
+A deposit can come from two places: a standard deposit by sending ether, or a change deposit. A change deposit is automatically generated when withdrawing funds from another deposit (standard or change). The entire deposited amount does not have to be withdrawn; for example, if 20 ether was deposited and only 12 is withdrawn, the system will make a new change deposit of 8 ether. The value of this change deposit is hashed, so someone looking at the chain cannot calculate `change deposit value + withdrawal value = old deposit value` and use the value to expose the original deposit.
+
+This EIP requires that [EIP-7708](./eip-7708.md) be in place along with an EIP to change receipts to SSZ format. This simplifies the proof as it only needs to verify a regular SHA256 Merkle branch verifying a log, there is no need to do verkle or RLP or other complex logic inside the proof. The log can be of two types: an EIP-7708 ETH transfer log, or a log generated by this EIP itself through the change mechanism.
+
+The EIP also includes a privacy pool mechanism where you must provide a privacy pool root, which corresponds to a list of deposits, so you prove that your deposit is one of the deposits in that list. Since this second Merkle branch mechanism is integrated into the proof, the marginal cost for a user to use it is zero, ensuring maximum adoption and maximizing the chance that privacy will be used responsibly. The privacy pools paper explains in much more detail the value of this privacy pools mechanism, and the benefits of an ecosystem where almost all legitimate users use it.
+
+The built-in PoW and 32 ETH limit prevent hash collision attacks: if an attacker can find collision `(x1, x2)` such that `create2_address(..., x1) = sha256(MAGIC_ADDRESS + x2)`, the attacker could extract their ether twice (but only twice). Such an attack requires approximately `2**80` hashes. Adding 24 bits of PoW increases the difficulty to `2**92`. This many hashes can be computed but is very difficult; currently, mining a Bitcoin block takes around `2**79` hashes, so those with the capabilities to attack this mechanism have a much more lucrative opportunity in Bitcoin mining.
 
 ### Scalability Implications
 
@@ -89,17 +150,15 @@ People should be able to use those minted Ethers for paying the gas fees.
 
 ## Reference Implementation
 
-A reference implementation is not ready yet, but here is a design:
+To be determined (TBD).
 
-- We will need to track all of the ETH transfers that are happening on the blockchain (Including those
-  initiated by smart-contracts), and add them to a ZK-friendly Sparse-Merkle-Tree. The amount sent should
-  also be included in the leaves.
-- We will need a new transaction type responsible for minting Ethers. The initiator should provide a proof
-  (Along with a nullifier) that proves he owns one of the leaves in the merkle-tree that has specific amount
-  of ETHers
+### ZK-SNARK Implementation
 
-Alternatively, we can use the already maintained state-trie and provide merkle-patricia-trie proofs, showing 
-that there exists some amount of ETH in an unspendable account, and mint them.
+Also TBD, but the implementation must meet the following conditions:
+
+* Use a transparent setup; ideally reuse the [EIP-4844](./eip-4844.md) setup. Do not use Groth16 or other application-specific setups.
+* The circuit should be directly verifiable without blindly trusting compilers like Circom. SHA256 is not too complicated and can be implemented using PLOOKUP with an 8-bit lookup table for arithmetic operations, which should suffice. There is no need to over-focus on prover efficiency.
+* Elliptic curves must still be used; Stark is too large.
 
 ## Security Considerations
 
@@ -108,3 +167,4 @@ In case of faulty implementation of this EIP, people may mint infinite amount of
 ## Copyright
 
 Copyright and related rights waived via [CC0](../LICENSE.md).
+