Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid view providers #4753

Merged
merged 16 commits into from
Jul 16, 2024
Merged

Add grid view providers #4753

merged 16 commits into from
Jul 16, 2024

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Apr 22, 2024

This adds a new plugin which expand the provider selection component.

@yann300 yann300 added the WIP label Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit f657828
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66960527adf352000875587c
😎 Deploy Preview https://deploy-preview-4753--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 requested a review from LianaHus April 25, 2024 13:50
@yann300 yann300 force-pushed the providers_grid branch 8 times, most recently from c6b24ff to 25e9ed1 Compare April 30, 2024 06:52
@yann300 yann300 added ready-to-review PR ready to review and removed WIP labels Apr 30, 2024
@yann300 yann300 force-pushed the providers_grid branch 4 times, most recently from c785e4b to 2b98039 Compare April 30, 2024 13:46
@Aniket-Engg
Copy link
Collaborator

Had a look. I think it is not quite user friendly yet.

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If Grid Providers is opened and we open Home Tab and click on pin another chain, it doesn't show grid providers tab
  • If we unpin vm-cancun, there is no selection in environment tab
  • We need to set the behavious if each environment is unpinned

@yann300 yann300 force-pushed the providers_grid branch 3 times, most recently from 4c25fdb to 620fd9f Compare May 10, 2024 08:57
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we unpin vm-cancun, there is no selection in environment tab This issue is still there.
Also, if you unpin an environment, it doesn't change the pin color and then we can not pin it again

@yann300 yann300 self-assigned this May 13, 2024
@yann300 yann300 force-pushed the providers_grid branch 3 times, most recently from c63731e to fc195c6 Compare May 13, 2024 08:14
@yann300 yann300 requested a review from Aniket-Engg July 1, 2024 15:08
@Aniket-Engg
Copy link
Collaborator

Aniket-Engg commented Jul 2, 2024

  • Screenshot 2024-07-02 at 3 43 59 PM

For L2 providers, text should be fixed

  • I think the name which will be visible in dropdown, should be shown on cards of home tab to make it easy to refer for users

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If I increase left side panel width, jsut a bit, it breaks UI for pins, see screen:
Screenshot 2024-07-02 at 7 01 20 PM
  • If I connect with hardhat provider, I can unpin Remix VM (Cancun) . When I disconnect the local hardhat node, it goes by default to Remix VM cancun and loads onnly accounts, nothing in env field
Screenshot 2024-07-02 at 6 55 51 PM

@Aniket-Engg
Copy link
Collaborator

Filter review:

  • Screenshot 2024-07-02 at 7 05 22 PM

When we use filter, if there are no match under certain providers, it should say No match found. Like for Injected and Externals in above screen

  • Screenshot 2024-07-02 at 7 06 45 PM

See, may be this gap between items on using Filter should be fixed

  • Screenshot 2024-07-02 at 7 08 18 PM

Filtering doesn't work on backspace in filter text box. See screen above

@Aniket-Engg
Copy link
Collaborator

  • If I increase left side panel width, jsut a bit, it breaks UI for pins, see screen:
Screenshot 2024-07-02 at 7 01 20 PM * If I connect with `hardhat provider`, I can unpin `Remix VM (Cancun)` . When I disconnect the local hardhat node, it goes by default to Remix VM cancun and loads onnly accounts, nothing in env field Screenshot 2024-07-02 at 6 55 51 PM

2nd issue in this comment is still there

@Aniket-Engg
Copy link
Collaborator

Filter review:

  • Screenshot 2024-07-02 at 7 05 22 PM

When we use filter, if there are no match under certain providers, it should say No match found. Like for Injected and Externals in above screen

  • Screenshot 2024-07-02 at 7 06 45 PM

See, may be this gap between items on using Filter should be fixed

  • Screenshot 2024-07-02 at 7 08 18 PM

Filtering doesn't work on backspace in filter text box. See screen above

last issue in this comment is still there

@Aniket-Engg
Copy link
Collaborator

I am merging this. Improvements can be tracked in #5005

@Aniket-Engg Aniket-Engg merged commit 4f82d42 into master Jul 16, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the providers_grid branch July 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants