Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query for unanswered risks #770

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

reinhardt
Copy link
Contributor

Ref syslabcom/scrum#2800

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what are the implication of this change for other projects that use Euphorie.

Anyway, I see that we have more or less the same statement here:
https://github.com/euphorie/osha.oira/blob/4d34265ee9383964ff3c095e92ce48cb4a3cf539/src/osha/oira/client/model.py#L166-L178

Is that just copy-pasted/dead code?

I approve based on trust, but I admit this change would take a lot more time to be reviewed, especially because of the implications on other projects.

The lack of tests for sure does not help.

@reinhardt
Copy link
Contributor Author

I have no idea what are the implication of this change for other projects that use Euphorie.

I'm reasonably sure that this is a sensible fix for eveyone. The query is supposed to return unanswered risks, as the name suggests, but it was returning many answered (identified) risks as well, which were then duplicated in the report.

Anyway, I see that we have more or less the same statement here: https://github.com/euphorie/osha.oira/blob/4d34265ee9383964ff3c095e92ce48cb4a3cf539/src/osha/oira/client/model.py#L166-L178

Is that just copy-pasted/dead code?

Thanks for pointing that out, I didn't know that. I'll look into it!

@reinhardt reinhardt merged commit cf61c5c into main Nov 21, 2024
2 checks passed
@reinhardt reinhardt deleted the scrum-2800-report-parked-risks branch November 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants