Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#208 replaced access to private attribute by public #209

Merged
merged 2 commits into from
Nov 7, 2024
Merged

#208 replaced access to private attribute by public #209

merged 2 commits into from
Nov 7, 2024

Conversation

ckunki
Copy link
Contributor

@ckunki ckunki commented Nov 6, 2024

Closes #208

tkilias
tkilias reviewed Nov 7, 2024
View reviewed changes
doc/user_guide/example-udf-script/create.sql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I look at the example, I am asking me, provides it any benefit to mention the proxies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you refer to mentioning the proxies in the user guide or using them in the example UDF?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the example

@ckunki ckunki merged commit d86ebb0 into main Nov 7, 2024
23 checks passed
@ckunki ckunki deleted the refactoring/#208-Replaced_access_to_private_attribute_by_public branch November 7, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace access to private attribute by public
2 participants
@ckunki @tkilias