Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#208 replaced access to private attribute by public #209

Merged
merged 2 commits into from
Nov 7, 2024
Merged

#208 replaced access to private attribute by public #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a47cb27
#208: Replaced access to private attribute by public
ckunki Nov 6, 2024
2661790
Applied change to doc/user_guide/example-udf-script/create.sql
ckunki Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/changes_0.1.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ Code name:
## Refactorings

* #188: Renamed global pytest fixtures to avoid name clashes
* #208: Replaced access to private attribute by public
2 changes: 1 addition & 1 deletion doc/user_guide/example-udf-script/create.sql
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I look at the example, I am asking me, provides it any benefit to mention the proxies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you refer to mentioning the proxies in the user guide or using them in the example UDF?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the example

Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class ExampleQueryHandler(UDFQueryHandler):
return f"{timestamp} {key} {self.parameter}"

def table_query_string(statement: str, **kwargs):
table_name = self.db_table_proxy._db_object_name.fully_qualified
table_name = self.db_table_proxy.fully_qualified
return statement.format(table_name=table_name, **kwargs)

def table_query(statement: str, **kwargs):
Expand Down