Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Orthographic View Toggle #942

Closed
wants to merge 1,262 commits into from
Closed

Add Orthographic View Toggle #942

wants to merge 1,262 commits into from

Conversation

lknknm
Copy link
Contributor

@lknknm lknknm commented Aug 8, 2023

As suggested on the Issue #885, this PR has the intention to continue developing the camera hotkeys feature.
This will implement the Ortographic View bound to the 5 key of the keyboard/numeric keyboard, using the vtkCamera::ParallelProjectionOn/Off() methods.

mwestphal and others added 30 commits March 20, 2023 08:45
Fix FREEDESKTOP usage in plugin cmake logic
Use cmake_minimum_required before project
…ig_file

    Use filesystem::path wherever possible
    Improve config file search testing
- Add support for reading config file directories (eg: `config.d`)
- Update doc
- Update configs
- Update tests

Needed for: f3d-app#374
Fix: f3d-app#597
Fix: f3d-app#417

New Loader API looks like this:

```
  /** 
   * Load a geometry from a provided file to the scene.
   * Reset the scene before loading if a full scene was loaded previously or if reset is set to false,
   * do not reset if only loaded geometries previously.
   * Geometries loader using this method will be available in a default scene and use all default
   * scene related options.
   * Throw a load_failure_exception on failure.
   */
  virtual loader& loadGeometry(const std::string& filePath, bool reset = false) = 0;

  /** 
   * Reset scene and load a full scene from provided file.
   * Please note default scene related options are not taken into account when loading a full scene.
   * Throw a load_failure_exception on failure.
   */
  virtual loader& loadScene(const std::string& filePath) = 0;

  /** 
   * Return true if the loader has a scene reader for the providen file, false otherwise.
   */
  virtual bool hasSceneReader(const std::string& filePath) = 0;

  /** 
   * Return true if the loader has a geometry reader for the providen file, false otherwise.
   */
  virtual bool hasGeometryReader(const std::string& filePath) = 0;
```

A new  command line option has been added to F3D:

`"group-geometries", "", "When opening multiple files, show them all in the same scene. Force geometry-only. The configuration file for the first file will be loaded."`
Config used be handled in the macOS bundle directly.
Now directly install them instead for simplicity sake.
When reloading or loading multiple files, actor properties
were not dynamically updated. They are now.

This issue is present in F3D v1.3.1.
…p#672)

 - Rename flags in the Configure/Configured logic as in the vtkF3DRendererWithColoring
 - Add some comments for future devs
- Introduce vtkF3DRenderer::UpdateActors which replace UpdateColoringActors
- Add Grid management to it to fix an issue with grid when loading multiple geometries
- Add testing
- Add comment for future devs
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@lknknm lknknm changed the title Add Ortographic View Toggle Add Orthographic View Toggle Aug 8, 2023
@mwestphal
Copy link
Contributor

any reason to open a new PR ? you can use the last one #924

@mwestphal mwestphal force-pushed the master branch 4 times, most recently from a8aac1c to 3f8eb1d Compare February 10, 2024 18:31
@mwestphal
Copy link
Contributor

superseeded by #1235

@mwestphal mwestphal closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants