Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow #9

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Add CI workflow #9

merged 1 commit into from
Sep 6, 2023

Conversation

rphibel
Copy link
Contributor

@rphibel rphibel commented Aug 8, 2023

No description provided.

Copy link
Contributor

@qdeslandes qdeslandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good first step, I've got a few improvement suggestions :)

I was expecting this workflow to be picked-up by Github for this PR, so I need to find out what's wrong. It's might be in the project settings.

.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@davide125
Copy link
Member

I was expecting this workflow to be picked-up by Github for this PR, so I need to find out what's wrong. It's might be in the project settings.

If you're adding a workflow for the first time it won't be run in the PR, you'll need to merge it blind. Future PRs should trigger it though.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0d9a59d). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   11.31%           
=======================================
  Files           ?       30           
  Lines           ?     2138           
  Branches        ?        0           
=======================================
  Hits            ?      242           
  Misses          ?     1896           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.clang-format Show resolved Hide resolved
@rphibel rphibel force-pushed the add-ci-workflow branch 2 times, most recently from 3833c08 to f14579b Compare September 4, 2023 13:11
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@rphibel rphibel force-pushed the add-ci-workflow branch 4 times, most recently from 88b58db to fe852fd Compare September 5, 2023 15:02
@qdeslandes
Copy link
Contributor

Looks all good to me! Thanks!

Screenshot 2023-09-06 at 12 27 23

@qdeslandes qdeslandes merged commit 17966db into facebook:main Sep 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants