edit spin Formula test procedure to verify installed version #18
Conversation
|
ok... I swear I looked in my repo to confirm I'd signed the commit before making the PR...... :| 
...not sure why DCO check failed, but following the bot's instructions & will resubmit PR. :| |
dimitrilw
force-pushed
the
17-spin-formula-test
branch
from
6e39499
to
31df714
Compare
There was a problem hiding this comment.
This is a great addition @dimitrilw! The test bot is quite picky. If the test loop is getting tiresome, i think the best command to test syntax locally is brew test-bot --only-tap-syntax
dimitrilw
force-pushed
the
17-spin-formula-test
branch
2 times, most recently
from
a92c701
to
6c5f8bb
Compare
Signed-off-by: Dimitri <[email protected]>
Signed-off-by: Dimitri <[email protected]>
Signed-off-by: Dimitri <[email protected]>
Signed-off-by: Dimitri <[email protected]>
dimitrilw
force-pushed
the
17-spin-formula-test
branch
from
0facc6d
to
7e58caf
Compare
|
@kate-goldenring , I apologize for being slow. I realize I will be docked 10 free-labor dollars on my monthly salary. 😂 File |
Signed-off-by: Dimitri <[email protected]>
|
I also just added a note to the Readme re running test-bot locally. I hope that out-of-scope addition is ok. |
|
@dimitrilw thank you for updating the readme too. I found running that command locally not very helpful (despite recommending it). Did you find that you were able to specify it to test a specific, yet to be installed formula? We also need to rebase this off latest main again. Sorry! I realized that adding testing for version is another place someone could mismatch version so i made an update in this PR to use the version variable throughout the formula which this could leverage: #21 |
|
I'll rebase pronto. Re local run: really no idea. I ran it. It didn't complain. Neither did the Cloud-CI run. Next time cloud run fails but local passes, then I can respond with "nope; no use." 😄 ...but until then, I will go with a healthy dose of faith that it does something, even if that "something" is just a placebo effect for me. |
|
Merge was not happy. Cleaner to push as new branch; please look to PR #22 . Apologies for the mess, @kate-goldenring . ....git. 🤷🏻 |
Performs version validation after installation & closes #17 .