17 spin forumula test rebase #22
Conversation
Signed-off-by: Dimitri <[email protected]>
Signed-off-by: Dimitri <[email protected]>
Signed-off-by: Dimitri <[email protected]>
Signed-off-by: Dimitri <[email protected]>
Signed-off-by: Dimitri <[email protected]>
Formula/spin.rb
Outdated
| @@ -40,6 +40,6 @@ def post_install | |||
| end | |||
|
|
|||
| test do | |||
| system "#{bin}/spin", "--version" | |||
| assert_match "spin 1.5.1 (8d4334e 2023-09-26)", shell_output("#{bin}/spin --version") | |||
There was a problem hiding this comment.
This should be updated to the latest version of Spin (2.0.1) but for simplicity, this can be made generic as follows once you've pulled in the latest commit that parametrizes version
| assert_match "spin 1.5.1 (8d4334e 2023-09-26)", shell_output("#{bin}/spin --version") | |
| assert shell_output("#{bin}/spin --version").start_with?("spin #{version}") |
There was a problem hiding this comment.
Spin version check updated to fixed 2.0.1 string, but using the start_with function in anticipation of parameterized formulas. Bart formula updated too.
…parameterized formulas Signed-off-by: Dimitri <[email protected]>
|
Re test-bot fail -- I ran it on my system (MacOS) and it was happy. 😂 |
Signed-off-by: Dimitri <[email protected]>
|
newlines added to end of both spin.rb & bart.rb -- I must have something in my VS-Code configs that is stripping them when I push from within VS-Code. 🤷🏻 More little details for me to look for. But good ol' terminal (vim & git-CLI) to the rescue! :) |
|
Oh! Wait... resubmitting. I see now that the version is already parameterized. I apologize. Fixing.... |
Signed-off-by: Dimitri <[email protected]>
|
@kate-goldenring , I believe it's good now. 😊 |
|
Ok, I have to admit that the test-bot is confounding. It failed me because I did not have a trailing new-line. So I added them, and it passed. ...then I realized the version parameters were already in-place, so I edited to reflect that and kept the new-line in. Now it fails on the existence of a new-line. 🤦🏻 ......fixing. I think. We'll see if test-bot agrees. |
Signed-off-by: Dimitri <[email protected]>
|
for ref, here's the fail message after commit 47bc4af ... I did not screenshot the previous pass (after adding newlines) or the previous fail (stating newlines needed to be added); not sure why test-bot hates contributors named Dimitri. 😄 |
for issue #18