Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17 spin forumula test rebase #22

Merged
merged 9 commits into from
Nov 14, 2023
Merged

17 spin forumula test rebase #22

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ad5447
edit spin Formula test procedure to verify installed version
dimitrilw Nov 14, 2023
15efdd4
fix test-bot ending empty line
dimitrilw Nov 14, 2023
2b6a120
and remove the new line...
dimitrilw Nov 14, 2023
8492144
remove steps_output & add gitignore
dimitrilw Nov 14, 2023
5c5b3db
add test-bot note to readme
dimitrilw Nov 14, 2023
db5ebfc
adjust both spin & bart version tests to use starts_with in prep for …
dimitrilw Nov 14, 2023
0f8767a
add newlines to appease test-bot
dimitrilw Nov 14, 2023
47bc4af
adjust formulas to use version parameter
dimitrilw Nov 14, 2023
2c9cba1
remove newlines...
dimitrilw Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
steps_output.txt
2 changes: 1 addition & 1 deletion Formula/spin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
system "#{bin}/spin", "plugins", "install", "cloud", "--yes"
end

test do

Check warning on line 42 in Formula/spin.rb

View workflow job for this annotation

GitHub Actions / test-bot (ubuntu-22.04)

`brew test --verbose fermyon/tap/spin` failed on Linux! 

/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/bin/bundle clean
==> Testing fermyon/tap/spin
==> /home/linuxbrew/.linuxbrew/Cellar/spin/2.0.1/bin/spin --version
Error: fermyon/tap/spin: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /spin\ 1\.5\.1\ \(8d4334e\ 2023\-09\-26\)/ to match "spin 2.0.1 (1d72f1c 2023-11-10)\n".
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.20.0/lib/minitest/assertions.rb:183:in `assert'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.20.0/lib/minitest/assertions.rb:295:in `assert_match'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/fermyon/homebrew-tap/Formula/spin.rb:49:in `block in <class:Spin>'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:2501:in `block (3 levels) in run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/extend/kernel.rb:499:in `with_env'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:2500:in `block (2 levels) in run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:1052:in `with_logging'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:2499:in `block in run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/mktemp.rb:75:in `block in run'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/mktemp.rb:75:in `chdir'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/mktemp.rb:75:in `run'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:2793:in `mktemp'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:2493:in `run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test.rb:44:in `block in <main>'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.10_1/lib/ruby/2.6.0/timeout.rb:93:in `block in timeout'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.10_1/lib/ruby/2.6.0/timeout.rb:33:in `block in catch'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.10_1/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.10_1/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.10_1/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test.rb:48:in `<main>'

Check warning on line 42 in Formula/spin.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13)

`brew test --verbose fermyon/tap/spin` failed on macOS Ventura (13)! 

/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/bin/bundle clean
==> Testing fermyon/tap/spin
==> /usr/local/Cellar/spin/2.0.1/bin/spin --version
Error: fermyon/tap/spin: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /spin\ 1\.5\.1\ \(8d4334e\ 2023\-09\-26\)/ to match "spin 2.0.1 (1d72f1c 2023-11-10)\n".
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.20.0/lib/minitest/assertions.rb:183:in `assert'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.20.0/lib/minitest/assertions.rb:295:in `assert_match'
/usr/local/Homebrew/Library/Taps/fermyon/homebrew-tap/Formula/spin.rb:49:in `block in <class:Spin>'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2501:in `block (3 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/extend/kernel.rb:499:in `with_env'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2500:in `block (2 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1052:in `with_logging'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2499:in `block in run_test'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:75:in `block in run'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:75:in `chdir'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:75:in `run'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2793:in `mktemp'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2493:in `run_test'
/usr/local/Homebrew/Library/Homebrew/test.rb:44:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:93:in `block in timeout'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `block in catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
/usr/local/Homebrew/Library/Homebrew/test.rb:48:in `<main>'
system "#{bin}/spin", "--version"
assert_match "spin 1.5.1 (8d4334e 2023-09-26)", shell_output("#{bin}/spin --version")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to the latest version of Spin (2.0.1) but for simplicity, this can be made generic as follows once you've pulled in the latest commit that parametrizes version

Suggested change
assert_match "spin 1.5.1 (8d4334e 2023-09-26)", shell_output("#{bin}/spin --version")
assert shell_output("#{bin}/spin --version").start_with?("spin #{version}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spin version check updated to fixed 2.0.1 string, but using the start_with function in anticipation of parameterized formulas. Bart formula updated too.

end
end
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,12 @@
## Documentation

`brew help`, `man brew` or check [Homebrew's documentation](https://docs.brew.sh).

## Contributing

Contributors are encouraged to run Homebrew's test-bot locally before submitting
a pull request.

```sh
brew test-bot --only-tap-syntax
```
Loading