-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement userAgent for Data Connect #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
reviewed
Sep 18, 2024
ncooke3
approved these changes
Sep 18, 2024
ncooke3
reviewed
Sep 18, 2024
aashishpatil-g
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending moving SDK version out of DataConnectSettings.
aashishpatil-g
approved these changes
Sep 18, 2024
firebase/firebase-ios-sdk#13639 has been merged. |
paulb777
force-pushed
the
pb-dc-userAgent
branch
from
September 19, 2024 20:27
966437e
to
7528abe
Compare
One test passed on rerun and will merge here. I'll investigate getting CI going smoothly next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add userAgent support and tests (it relies on unreleased until 11.3.0 Firebase main)
Add environment variable support to use Firebase main instead of a released version.
To develop going forward, close Xcode and restart with
FIREBASE_MAIN=yes open Package.swift