Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement userAgent for Data Connect #8

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Implement userAgent for Data Connect #8

merged 3 commits into from
Sep 19, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 18, 2024

Add userAgent support and tests (it relies on unreleased until 11.3.0 Firebase main)

Add environment variable support to use Firebase main instead of a released version.

To develop going forward, close Xcode and restart with FIREBASE_MAIN=yes open Package.swift

Copy link
Collaborator

@aashishpatil-g aashishpatil-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending moving SDK version out of DataConnectSettings.

Package.swift Outdated Show resolved Hide resolved
@ncooke3
Copy link
Member

ncooke3 commented Sep 19, 2024

firebase/firebase-ios-sdk#13639 has been merged.

@paulb777
Copy link
Member Author

One test passed on rerun and will merge here.

I'll investigate getting CI going smoothly next.

@paulb777 paulb777 merged commit f4b722b into main Sep 19, 2024
4 of 18 checks passed
@paulb777 paulb777 deleted the pb-dc-userAgent branch September 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants