Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update MSR baselines for T2CL on kernel 5.10 #4103

Merged

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Sep 12, 2023

Now that our kernel 5.10 AMIs have the KVM patch to enable GDS_NO when the required microcode is installed on the host, updates MSR baselines.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Now that our kernel 5.10 AMIs have the KVM patch to enable GDS_NO when
the required microcode is installed on the host, updates MSR baselines.

Signed-off-by: Patrick Roy <[email protected]>
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3adf2aa) 82.35% compared to head (2df8b02) 82.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4103   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files         225      225           
  Lines       28469    28469           
=======================================
  Hits        23447    23447           
  Misses       5022     5022           
Flag Coverage Δ
4.14-c7g.metal 77.78% <ø> (+<0.01%) ⬆️
4.14-m5d.metal 79.67% <ø> (ø)
4.14-m6a.metal 78.78% <ø> (ø)
4.14-m6g.metal 77.78% <ø> (ø)
4.14-m6i.metal 79.65% <ø> (ø)
5.10-c7g.metal 80.69% <ø> (ø)
5.10-m5d.metal 82.34% <ø> (ø)
5.10-m6a.metal 81.55% <ø> (ø)
5.10-m6g.metal 80.69% <ø> (ø)
5.10-m6i.metal 82.33% <ø> (ø)
6.1-c7g.metal 80.69% <ø> (ø)
6.1-m5d.metal 82.34% <ø> (ø)
6.1-m6a.metal 81.55% <ø> (ø)
6.1-m6g.metal 80.69% <ø> (ø)
6.1-m6i.metal 82.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wearyzen wearyzen merged commit dc9f432 into firecracker-microvm:main Sep 13, 2023
5 checks passed
@roypat roypat deleted the update-msr-baselines-t2cl-5.10 branch April 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants