Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removed unusable devctr guide #4148

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

JonathanWoollett-Light
Copy link
Contributor

Changes

Removed out of date guide (devctr-image.md) for updating the dev container image.

Reason

The guide could not be used by non-maintainers.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed labels Oct 3, 2023
@JonathanWoollett-Light JonathanWoollett-Light self-assigned this Oct 3, 2023
roypat
roypat previously approved these changes Aug 13, 2024
@roypat roypat added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting review Indicates that a pull request is ready to be reviewed labels Sep 12, 2024
roypat
roypat previously approved these changes Sep 12, 2024
pb8o
pb8o previously approved these changes Sep 12, 2024
From: Jonathan Woollett-Light <[email protected]>

Removed out of date guide (`devctr-image.md`) for updating the dev
container image as the guide could not be used by non-maintainers.

Update the link from the 0.22.0 changelog to point towards the 0.22.0
branch.

Signed-off-by: Jonathan Woollett-Light <[email protected]>
Co-authored-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
@roypat roypat dismissed stale reviews from pb8o and themself via 375c835 September 12, 2024 16:33
@pb8o pb8o merged commit 8eea9df into firecracker-microvm:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants