Release 1.5 postperations #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4153 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 223 223
Lines 28448 28448
=======================================
Hits 23609 23609
Misses 4839 4839
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
wearyzen
as code owners
roypat
added
the
Status: Awaiting review
We are starting 1.6.0 development once the 1.5.0 release is done. Signed-off-by: Patrick Roy <[email protected]>
pb8o
previously approved these changes
Oct 9, 2023
zulinx86
previously approved these changes
Oct 9, 2023
zulinx86
approved these changes
Oct 9, 2023
With the new CI artifacts system, we no longer keep all firecracker releases in a single S3 bucket, and instead keep a folder of supported firecracker releases per artifacts folder. This means that in the 1.6 artifacts folder, only 1.4 and 1.5 release binaries exist. Therefore, the additional check in firecracker_artifacts() is no longer needed. We remove it, because it specifies the minimal version as a tuple, and is thus easily missed when doign a release (as the runbook only hints that sometimes min-versions are specified as strings). Signed-off-by: Patrick Roy <[email protected]>
fixed :) thankfully we can update commit messages without dismissing approvals lol |
pb8o
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that need to happen after the release branch was taken
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.