tests: Warn on clippy::as_conversions
#4161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
added
the
Priority: Low
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4161 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 223 223
Lines 28508 28508
=======================================
Hits 23656 23656
Misses 4852 4852
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
`clippy::ptr_as_ptr`, `clippy::cast_lossless`, `clippy::cast_possible_truncation`, `clippy::cast_possible_wrap` and `clippy::cast_sign_loss` are all enabled by `clippy::as_conversions`, with them all enabled we can now remove them and simply warn on `clippy::as_conversions`. Signed-off-by: Jonathan Woollett-Light <[email protected]>
JonathanWoollett-Light
force-pushed
the
as_conversions
branch
from
fd4bd31 to
9e27796
Compare
|
Seems like this needs some allows sprinkled throughout the test code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See below.
Reason
clippy::ptr_as_ptr,clippy::cast_lossless,clippy::cast_possible_truncation,clippy::cast_possible_wrapandclippy::cast_sign_lossare all enabled byclippy::as_conversions, with them all enabled we can now remove them and simply warn onclippy::as_conversions.Closes #3161.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.