Fix nightly pr failures #4206
Merged
Fix nightly pr failures #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ddd9836 a mistake was introduced for `DEFAULT_G3_FEATURES_NO_SSBS_4_14`. Correct it here. Fixes: ddd9836 Signed-off-by: Pablo Barbáchano <[email protected]>
Commit c44b0c6 was refactored in such a way that we could not find an exception for custom CPU templates. It was probably not noticed since the it requires a specific CPU in m5d. Fixes: c44b0c6 Signed-off-by: Pablo Barbáchano <[email protected]>
We compile the UFFD and seccomp example programs as a session fixture. If we run the tests in parallel, there is one session per worker and we end up downloading and compiling the examples for each worker (worst case). Instead, use the same approach as the Firecracker and jailer binaries. Signed-off-by: Pablo Barbáchano <[email protected]>
Currently the test fails when running it outside of a PR, because the checker returns an exit code of 2. Fixes: f79d301 Signed-off-by: Pablo Barbáchano <[email protected]>
pb8o
added
Priority: High
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
=======================================
Coverage 82.93% 82.93%
=======================================
Files 221 221
Lines 28231 28231
=======================================
Hits 23414 23414
Misses 4817 4817
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The test fails when not run as part of PR tests. The issue is that these tests behave differently when running as part of a PR or independently. This makes testing and troubleshooting more difficult. Workaround the issue by changing the directory so the command runs at the right place. Fixes: 8297c8f Signed-off-by: Pablo Barbáchano <[email protected]>
pb8o
added
Status: Awaiting review
wearyzen
reviewed
Oct 30, 2023
wearyzen
approved these changes
Oct 30, 2023
ShadowCurse
approved these changes
Oct 30, 2023
bchalios
requested changes
Oct 30, 2023
bchalios
approved these changes
Oct 30, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PRs #4149 and #4188 had a few regressions bugs that were not reachable from the normal PR tests.
In addition, add a change so we only compile example binaries once, instead of once per worker. This avoids downloading and compiling code.
Reason
To make all pipelines pass.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.