Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly pr failures #4206

Merged
merged 5 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/framework/ab_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,15 @@ def git_ab_test_host_command_if_pr(
command: str,
*,
comparator: Callable[[CommandReturn, CommandReturn], bool] = default_comparator,
**kwargs,
):
"""Runs the given bash command as an A/B-Test if we're in a pull request context (asserting that its stdout and
stderr did not change across the PR). Otherwise runs the command, asserting it returns a zero exit code
"""
if is_pr():
git_ab_test_host_command(command, comparator=comparator)
else:
utils.run_cmd(command)
utils.run_cmd(command, **kwargs)


def git_ab_test_host_command(
Expand Down
1 change: 1 addition & 0 deletions tests/integration_tests/security/test_vulnerabilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ def test_spectre_meltdown_checker_on_host(spectre_meltdown_checker):
comparator=set_did_not_grow_comparator(
spectre_meltdown_reported_vulnerablities
),
ignore_return_code=True,
pb8o marked this conversation as resolved.
Show resolved Hide resolved
)


Expand Down