Make public_ip and domain_name top level config keys #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bakhtin <[email protected]>
metachris
reviewed
Dec 2, 2024
| "public_listen_addr": "0.0.0.0:5544", | ||
| "cert_hosts": "1.2.3.4,localhost,127.0.0.1", |
There was a problem hiding this comment.
what's the rationale for replacing cert_hosts with a fixed IP and DNS entry? should be fine anyway, just curious
There was a problem hiding this comment.
It is easier to compose a string with CN names for the certificate from the individual components like IP address and DNS name when needed. Top level IP address and DNS name may come in handy for some other services (though we don't have a use case right now).
metachris
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
⛱ Motivation and Context
Multiple services require
public_ipanddns_namekeys for TLS cert generation. To not duplicate move them to top level.📚 References
✅ I have run these commands
make lintmake testgo mod tidy