Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public_ip and domain_name top level config keys #24

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Make public_ip and domain_name top level config keys #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions testdata/get-configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"instance_name": "tdx-multioperator-builder-01",
"public_ip": "1.2.3.4",
"dns_name": "multioperator-builder-01.builder.flashbots.net",
"rclone": {
"__version": "v1.66.0-DEV",
"access_key_id": "string",
Expand All @@ -12,9 +14,8 @@
"orderflow_proxy": {
"flashbots_orderflow_signing_address": "0x00",
"builder_endpoint": "http://127.0.0.1:8645",
"local_listen_addr": "0.0.0.0:443",
"local_listen_addr": "127.0.0.1:3443",
"public_listen_addr": "0.0.0.0:5544",
"cert_hosts": "1.2.3.4,localhost,127.0.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the rationale for replacing cert_hosts with a fixed IP and DNS entry? should be fine anyway, just curious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easier to compose a string with CN names for the certificate from the individual components like IP address and DNS name when needed. Top level IP address and DNS name may come in handy for some other services (though we don't have a use case right now).

"builder_confighub_endpoint": "http://127.0.0.1:7937",
"orderflow_archive_endpoint": "https://orderflow-archive.flashbots.net",
"conn_per_peer": "50"
Expand Down