[WIP]Feat: add EIP-1559 transaction type #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested changes
Jan 5, 2024
| @@ -38,7 +53,26 @@ library Transactions { | |||
| return RLPWriter.writeList(items); | |||
| } | |||
|
|
|||
| function decodeRLP(bytes memory rlp) internal pure returns (Legacy memory) { | |||
| function encodeRLP(EIP1559 memory txStruct) internal pure returns (bytes memory) { | |||
| bytes[] memory items = new bytes[](12); | |||
There was a problem hiding this comment.
I just fixed this, lmk if it is still not correct.
src/Transactions.sol
Outdated
| bytes v; | ||
| } | ||
|
|
||
| function encodeLegacyRLP(Legacy memory txStruct) internal pure returns (bytes memory) { |
There was a problem hiding this comment.
Can you keep the same name here? I imagine having the same encodeRLP name overloaded for both transactions.
|
I made some changes to the encoding of legacy transactions. You'll need to pull the new changes. |
Cool will do. |
|
Hey @haythemsellami. Do you need any help on the PR? |
Trying to finish the test and make it working, but I may have a bug in the encoding implementation as the output is not matching(maybe the access list encoding is wrong?) |
|
Closing this in favour of #36. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.