-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Feat: add EIP-1559 transaction type #12
Closed
haythemsellami
wants to merge
14
commits into
flashbots:main
from
eaglelabs-consulting:feat/eip1559-transaction
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3635455
feat: encodeRLP for eip-1559 tx
haythemsellami d15ea8b
feat: decodeRLP for eip-1559 tx
haythemsellami c95fe63
Merge branch 'main' into feat/eip1559-transaction
haythemsellami 9571d8d
merge
haythemsellami 3ceb18b
rename
haythemsellami cf547cc
fix: EIP1559 encoding
haythemsellami 48ddc42
fix: addding tx type
haythemsellami d437383
fix rlp encoding accessList
haythemsellami 49273a5
fix decodeRLP()
haythemsellami 4f2908d
fix
haythemsellami 4b5de7d
fix
haythemsellami de2e819
fix
haythemsellami 86198be
fix
haythemsellami 0bcddc3
fix
haythemsellami File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this encoding correct?
EIP-1559
transactions are encoded withEIP-2718
format, so it needs to have the transaction type prefixed. You can find a code reference here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just fixed this, lmk if it is still not correct.