Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear environment variables #414

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Don't clear environment variables #414

merged 4 commits into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. utils: Stop filtering environment variables 

    The logic of it makes sense - prevent programs from accessing sensitive
environment variables. However, we have no idea whether the programs
being executed depend on those environment variables. It would be
entirely understandable if a tool to inspect a remote repository
required authentication, for example. The broad filtering being done
also makes it likely that an insensitive environment variable was
removed. There's really no way to win that game.

This also fixes an issue where GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL were
being filtered out of the commit command. This appears to be a bug in
python since the altered environment somehow escaped past its usage and
only via subprocess. In any case, removing the filtering fixes the
problem.

Fixes: flathub-infra#413
    @dbnicholson
    dbnicholson committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f7aad80 View commit details
    Browse the repository at this point in the history

  2. tests: Clear git commit environment variables 

    In order to test the data added to git commits, clear the associated
environment variables so that the test fully manages inputs.
    @dbnicholson
    dbnicholson committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bc027a4 View commit details
    Browse the repository at this point in the history

  3. tests: Check git commit data 

    Test that the git commit was made with the correct values in the
metadata. Primarily this is useful to make sure that commit authorship
is being done correctly.
    @dbnicholson
    dbnicholson committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f82612b View commit details
    Browse the repository at this point in the history

  4. README: Remove suggestion to set EMAIL environment variable 

    It has no effect if GIT_AUTHOR_EMAIL is being processed correctly.
    @dbnicholson
    dbnicholson committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    609991c View commit details
    Browse the repository at this point in the history