Don't clear environment variables #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbnicholson
force-pushed
the
no-clear-env
branch
from
fb39413
to
a70f57a
Compare
Merged
dbnicholson
force-pushed
the
no-clear-env
branch
from
a70f57a
to
ece5226
Compare
It should. Rebased now. |
And yet |
The logic of it makes sense - prevent programs from accessing sensitive environment variables. However, we have no idea whether the programs being executed depend on those environment variables. It would be entirely understandable if a tool to inspect a remote repository required authentication, for example. The broad filtering being done also makes it likely that an insensitive environment variable was removed. There's really no way to win that game. This also fixes an issue where GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL were being filtered out of the commit command. This appears to be a bug in python since the altered environment somehow escaped past its usage and only via subprocess. In any case, removing the filtering fixes the problem. Fixes: flathub-infra#413
In order to test the data added to git commits, clear the associated environment variables so that the test fully manages inputs.
Test that the git commit was made with the correct values in the metadata. Primarily this is useful to make sure that commit authorship is being done correctly.
It has no effect if GIT_AUTHOR_EMAIL is being processed correctly.
dbnicholson
force-pushed
the
no-clear-env
branch
from
ece5226
to
609991c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the first commit for discussion, but basically it can't be done correctly like this and it was causing the
GIT_AUTHOR_*environment variables to be unset when making commits. A couple tests are added to make sure that doesn't happen again.Fixes: #413