Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flake8 on CI #415

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Run flake8 on CI #415

merged 5 commits into from
Apr 30, 2024

Conversation

dbnicholson
Copy link
Contributor

black only does formatting while flake8 is a linter, so it's good to run both. In order to get there:

  • Fix a failing test (I can split this out if preferred)
  • Fix a recent black diff (this is also in Don't clear environment variables #414)
  • Fix all the existing flake8 warnings and errors
  • Install and run flake8 from the formatting workflow job

@dbnicholson
tests: Fix chromium checker test
f1f61d7 
It appears that all versions of chromium < 100 and LLVM < 14 have been
removed from the Google server. It would be better if the tests didn't
rely on real resources from the network, but that's a big can of worms
here. Update accordingly.
@dbnicholson
Fix black error
b56cc35 
Apparently newer black prefers the ellipsis on the same line.
@dbnicholson
Make flake8 config matching black
efa4818 
While flake8 thinks you shouldn't have a space before `:`, black thinks
you should. Silence flake8 since the code is expected to be formatted
with black.
@dbnicholson
Fix all the flake8 warnings and errors
dd676fc 
There should be no functional changes here. Mostly there were line too
long warnings. After this both flake8 and black pass.
@dbnicholson
ci: Run flake8 in addition to black
a9a32e1 
black is a formatter while flake8 is a linter. Both are good to use.
@wjt wjt merged commit ac28f16 into flathub-infra:master Apr 30, 2024
3 checks passed
@wjt wjt mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjt wjt wjt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbnicholson @wjt