-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell: workflow, config and fix typos it finds #1226
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
18459b7
Add rudimentary codespell config
yarikoptic 17b52d1
Some custom skips for codespell
yarikoptic af14310
Do not git ignore bin/ since it has caiman_gui.py
yarikoptic 87e095c
skip ptd
yarikoptic ecaaea4
[DATALAD RUNCMD] Do interactive fixing of some ambigous typos
yarikoptic e5c9ad0
Ignore name Manuel from codespell
yarikoptic 81ccd7e
Also ignore "thre"
yarikoptic d2ac1e4
[DATALAD RUNCMD] Fix pathes typo
yarikoptic 5504535
skip recuse
yarikoptic 7b09601
[DATALAD RUNCMD] run codespell throughout fixing typo automagically
yarikoptic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -720,7 +720,7 @@ def distance_masks(M_s:list, cm_s: list[list], max_dist: float, enclosed_thr: Op | |
for gt_comp, test_comp, cmgt_comp, cmtest_comp in zip(M_s[:-1], M_s[1:], cm_s[:-1], cm_s[1:]): | ||
|
||
# todo : better with a function that calls itself | ||
# not to interfer with M_s | ||
# not to interfere with M_s | ||
gt_comp = gt_comp.copy()[:, :] | ||
test_comp = test_comp.copy()[:, :] | ||
|
||
|
@@ -753,8 +753,8 @@ def distance_masks(M_s:list, cm_s: list[list], max_dist: float, enclosed_thr: Op | |
# if we don't have even a union this is pointless | ||
if union > 0: | ||
|
||
# intersection is removed from union since union contains twice the overlaping area | ||
# having the values in this format 0-1 is helpfull for the hungarian algorithm that follows | ||
# intersection is removed from union since union contains twice the overlapping area | ||
# having the values in this format 0-1 is helpful for the hungarian algorithm that follows | ||
D[i, j] = 1 - 1. * intersection / \ | ||
(union - intersection) | ||
if enclosed_thr is not None: | ||
|
@@ -791,7 +791,7 @@ def find_matches(D_s, print_assignment: bool = False) -> tuple[list, list]: | |
matches.append(indexes) | ||
DD = D.copy() | ||
total = [] | ||
# we want to extract those informations from the hungarian algo | ||
# we want to extract those information from the hungarian algo | ||
for row, column in indexes2: | ||
value = DD[row, column] | ||
if print_assignment: | ||
|
@@ -1095,7 +1095,7 @@ def extract_binary_masks_blob(A, | |
|
||
Args: | ||
A: scipy.sparse matrix | ||
contains the components as outputed from the CNMF algorithm | ||
contains the components as outputted from the CNMF algorithm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll have to circle back to this later; the phrasing is weird. |
||
|
||
neuron_radius: float | ||
neuronal radius employed in the CNMF settings (gSiz) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting we never caught this before