Fix caiman temp mcorr offline #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev -> Master
Merge dev to master for release (1.9.9)
kushalkolar
added a commit
to nel-lab/mesmerize-core
that referenced
this pull request
May 25, 2022
fixes necessary for these changes have been merged upstream and have been released on `conda-forge` flatironinstitute/CaImAn#978
This was referenced May 30, 2022
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #977, dir is prefixed onto
base_namefor offline mcorr. Previously it only applied to online mcorrSee also: #948 (comment)
Tested using
pytest, both with and without theCAIMAN_TEMPstuff. Works in both cases.(also works downstream in mesmerize land, been needing this fix so I can finally get CI going in mesmerize-core 😄 )