Started basis examples #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests are failing and I will fix them tomorrow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 20 20
Lines 1857 1857
=======================================
Hits 1803 1803
Misses 54 54 ☔ View full report in Codecov by Sentry. |
|
Fixed comments from PR: #251 Added examples to |
BalzaniEdoardo
requested changes
Oct 25, 2024
billbrod
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Variety of changes requested, but the same themes repeated.
In particular, I think we shouldn't show the to_transformer method in the example of the basis init method. It's not the "standard use case" for the basis object, which is what those should be showing
BalzaniEdoardo
approved these changes
Oct 28, 2024
billbrod
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deleted the old glm redundant branch and created a new one. I included the comments Edoardo made on the previous basis PR. But I need to add more examples for the subclasses and inherited methods and double check that all docstring results are correct. Hope everything is clean now!
Old basis branch PR: #251