Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version constraints for pkg:web >=0.3.0 <0.5.0 #6730

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

srujzs
Copy link
Contributor

@srujzs srujzs commented Nov 14, 2023

package:web 0.4.0 restricts types to not be subtypes of JSObject until we migrate those types to extension types. Flutter pins package:web to 0.3.0, so packages targeting 3.2 should support this version range for now.

@srujzs srujzs requested a review from a team as a code owner November 14, 2023 22:36
@srujzs srujzs requested review from kenzieschmoll and removed request for a team November 14, 2023 22:36
@kenzieschmoll
Copy link
Member

Does this PR mean we can use helpers like createIFrameElement and address the final package:web migration todo here? #6606 (comment)

@srujzs
Copy link
Contributor Author

srujzs commented Nov 15, 2023

Maybe. It really depends on whether we can move this straight to ^0.4.0 or if we need the version range. If the former, then yes, and if the latter, then not yet.

package:web 0.4.0 restricts types to not be subtypes of JSObject
until we migrate those types to extension types. Flutter pins
package:web to 0.3.0, so packages targeting 3.2 should support
this version range for now.
@srujzs srujzs merged commit c2b1e60 into flutter:master Nov 15, 2023
19 checks passed
srujzs added a commit to srujzs/devtools that referenced this pull request Nov 15, 2023
)"

This reverts commit c2b1e60.

Seeing some breakages in using pkg:web 0.3.0 for some reason, will
investigate.
kenzieschmoll pushed a commit that referenced this pull request Nov 15, 2023
…6739)

This reverts commit c2b1e60.

Seeing some breakages in using pkg:web 0.3.0 for some reason, will
investigate.
srujzs added a commit that referenced this pull request Nov 15, 2023
kenzieschmoll pushed a commit that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants