Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version constraints for pkg:web >=0.3.0 <0.5.0 #6730

Merged
merged 1 commit into from
Nov 15, 2023
+11 −5
Merged

Set version constraints for pkg:web >=0.3.0 <0.5.0 #6730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/devtools_app/lib/src/shared/config_specific/import_export/_export_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,17 @@ class ExportControllerWeb extends ExportController {
final element = document.createElement('a') as HTMLAnchorElement;
element.setAttribute(
'href',
URL.createObjectURL(Blob([content.toJS].toJS)),
// TODO(srujzs): This is necessary in order to support package:web 0.4.0.
// This was not needed with 0.3.0, hence the lint.
// ignore: avoid-unnecessary-type-casts
URL.createObjectURL(Blob([content.toJS].toJS) as JSObject),
);
element.setAttribute('download', fileName);
element.style.display = 'none';
(document.body as HTMLBodyElement).append(element);
// TODO(srujzs): This is necessary in order to support package:web 0.4.0.
// This was not needed with 0.3.0, hence the lint.
// ignore: avoid-unnecessary-type-casts
(document.body as HTMLBodyElement).append(element as JSAny);
element.click();
element.remove();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ dependencies:
vm_service: ^13.0.0
# TODO https://github.com/dart-lang/sdk/issues/52853 - unpin this version
vm_snapshot_analysis: 0.7.2
web: ^0.3.0
web: '>=0.3.0 <0.5.0'
web_socket_channel: ^2.1.0
# widget_icons: ^0.0.1

Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app_shared/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:
meta: ^1.9.1
pointer_interceptor: ^0.9.3+3
vm_service: ^13.0.0
web: ^0.3.0
web: '>=0.3.0 <0.5.0'

dev_dependencies:
flutter_lints: ^2.0.3
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_extensions/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
path: ^1.8.0
logging: ^1.1.1
vm_service: ^13.0.0
web: ^0.3.0
web: '>=0.3.0 <0.5.0'

dev_dependencies:
flutter_driver:
Expand Down