fix(connectivity_plus): Return valid connection type when only one available #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r multiple being active
|
On which platform did you get this error? I would like to look it up and ensure that the stream always returns an array |
miquelbeltran
approved these changes
Mar 10, 2024
|
On Android |
8 tasks
2 tasks
|
I hope this issue will be fixed soon. |
Do you experience this issue? It never made it to the stable release of the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was working on updates for example app to show newly added multiple connection types feature in a more nice way and found a bug that when only one connection type is available there is an exception in the platform interface as returned result isn't a list, but a String:
This PR fixes mentioned bug and also updates the example UI to look better:
Before
After
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).