fix: efb and installer links #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pdellaert
requested changes
Nov 8, 2024
src/constants/links.ts
Outdated
| @@ -7,4 +7,6 @@ export const links: {[name: string]: string} = { | |||
| facebook: 'https://www.facebook.com/FlyByWireSimulations/', | |||
| opencollective: 'https://opencollective.com/flybywire', | |||
| docsfaq: 'https://docs.flybywiresim.com/faq', | |||
| installer: 'https://cdn.flybywiresim.com/installer/release/FlyByWire_Installer_Setup.exe', | |||
There was a problem hiding this comment.
Can we change this to the CF link?
Suggested change
| installer: 'https://cdn.flybywiresim.com/installer/release/FlyByWire_Installer_Setup.exe', | |
| installer: 'https://flybywirecdn.com/installer/release/FlyByWire_Installer_Setup.exe', |
There was a problem hiding this comment.
Actioned, wasn't aware that we changed service for this, fixed another location that used old link.
pdellaert
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of changes
EFB links changed on footer, and projects index to reflect new URL.
Installer link also fixed on footer to actually do something
Installer link on download updated to CF link
Screenshots(if applicable)
< Provide screenshots of the affected areas if applicable to support your changes being made ensuring you show the full scope of the area changed and surrounding content, this allows for faster reviews on PRs. >