Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: efb and installer links #532

Merged
merged 3 commits into from
Nov 8, 2024
Merged

fix: efb and installer links #532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9588031
fix: efb and installer links
NathanInnes Nov 8, 2024
053277b
fix: update cdn link to cf
NathanInnes Nov 8, 2024
7e725f5
Merge branch 'staging' into fix-efb-installer-links
NathanInnes Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Navigation/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ const Footer = () => (

<div className="grid grid-cols-3 items-start gap-x-32 gap-y-5">
<NavWrapper label="Projects">
<NavItem label="Installer" href="/" />
<NavItem label="Installer" href={links.installer} />
<NavItem label="A32NX" href="/projects/downloadLinks" />
<NavItem label="A380X" href="/projects/a380x" />
<NavItem label="EFB" href="/" />
<NavItem label="EFB" href={links.efb} />
</NavWrapper>

<NavWrapper label="Menu">
Expand Down
2 changes: 2 additions & 0 deletions src/constants/links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ export const links: {[name: string]: string} = {
facebook: 'https://www.facebook.com/FlyByWireSimulations/',
opencollective: 'https://opencollective.com/flybywire',
docsfaq: 'https://docs.flybywiresim.com/faq',
installer: 'https://cdn.flybywiresim.com/installer/release/FlyByWire_Installer_Setup.exe',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to the CF link?

Suggested change
installer: 'https://cdn.flybywiresim.com/installer/release/FlyByWire_Installer_Setup.exe',
installer: 'https://flybywirecdn.com/installer/release/FlyByWire_Installer_Setup.exe',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actioned, wasn't aware that we changed service for this, fixed another location that used old link.

efb: 'https://docs.flybywiresim.com/aircraft/common/flypados3',
};
5 changes: 2 additions & 3 deletions src/pages/projects/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import { NextPage } from 'next';
import Section from '../../components/Utils/Section';
import Container from '../../components/Utils/Container';
import Card from '../../components/Projects/Card';

// const A32NX_DOWNLOAD_URL = 'https://github.com/flybywiresim/a32nx/releases/download/assets/master/A32NX-master.zip';
import { links } from '../../constants/links';

const index: NextPage = () => (
<>
Expand Down Expand Up @@ -49,7 +48,7 @@ const index: NextPage = () => (
title="EFB"
category="Software"
description="The Electronic Flight Bag is an integrated tablet with a wide array of tools, settings and more."
href="https://docs.flybywiresim.com/fbw-a32nx/feature-guides/flypados3/"
href={links.efb}
direction="horizontal"
/>
</div>
Expand Down
Loading