Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STUTL-45 implement escapeCqlWildcards #86

Merged
merged 4 commits into from
Jun 5, 2024
Merged

STUTL-45 implement escapeCqlWildcards #86

merged 4 commits into from
Jun 5, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Jun 3, 2024

Implement a new function to escape all five CQL wildcards, instead of just two as was done in escapeCqlValue():

  • asterisk (*)
  • question mark (?)
  • caret (^)
  • backslash ()
  • quote (")

Refs STUTL-45, STUTL-33

Implement a new function to escape all five CQL wildcards, instead of
just two as was done in `escapeCqlValue()`:
* asterisk (*)
* question mark (?)
* caret (^) (sic)
* backslash (\)
* quote (")

Refs STUTL-45, STUTL-33
@zburke zburke requested review from julianladisch and JohnC-80 June 3, 2024 14:20
Copy link

github-actions bot commented Jun 3, 2024

Jest Unit Test Statistics

  1 files  ±0  10 suites  +1   5s ⏱️ -1s
51 tests +3  51 ✔️ +3  0 💤 ±0  0 ±0 
54 runs  +6  54 ✔️ +6  0 💤 ±0  0 ±0 

Results for commit 5503323. ± Comparison against base commit 2be3794.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 3, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 5503323. ± Comparison against base commit 2be3794.

♻️ This comment has been updated with latest results.

* * quote (")
*
* @param string a string
* @return string the input string with CQL's special characters escaped
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSDoc of escapeCqlWildcards and escapeCqlValue may refer to each other using @see and @link.

Copy link
Contributor

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link

sonarcloud bot commented Jun 5, 2024

@zburke zburke merged commit 99f4431 into master Jun 5, 2024
6 checks passed
@zburke zburke deleted the STUTL-45 branch June 5, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants