-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STUTL-45 implement escapeCqlWildcards #86
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/** | ||
* Escape all CQL wildcard characters in a string by pre-pending each with | ||
* a single backslash (\). Wildcards are given by | ||
* https://www.loc.gov/standards/sru/cql/contextSets/theCqlContextSet.html | ||
* (see the section "Masking"): | ||
* | ||
* * asterisk (*) | ||
* * question mark (?) | ||
* * caret (^) (sic) | ||
* * backslash (\) | ||
* * quote (") | ||
* | ||
* @see escapeCqlValue for a function that only escapes quote and backslash, | ||
* desirable functionality when the argument wants those characters to | ||
* function as wildcards. | ||
* | ||
* @param string a string | ||
* @return string the input string with CQL's special characters escaped | ||
*/ | ||
export default function escapeCqlWildcards(str) { | ||
return str.replace(/[*?^"\\]/g, c => '\\' + c); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import escapeCqlWildcards from './escapeCqlWildcards'; | ||
|
||
describe('correctly escapes CQL special characters', () => { | ||
test('does not modify non-special strings', () => { | ||
const str = 'abc'; | ||
expect(escapeCqlWildcards(str)).toEqual(str); | ||
}); | ||
|
||
test('escapes asterisk (*) with a backslash', () => { | ||
const str = 'a*b*c'; | ||
expect(escapeCqlWildcards(str)).toEqual('a\\*b\\*c'); | ||
}); | ||
|
||
test('escapes question mark (?) with a backslash', () => { | ||
const str = 'a?b?c'; | ||
expect(escapeCqlWildcards(str)).toEqual('a\\?b\\?c'); | ||
}); | ||
|
||
test('escapes caret (^) with a backslash', () => { | ||
const str = 'a^b^c'; | ||
expect(escapeCqlWildcards(str)).toEqual('a\\^b\\^c'); | ||
}); | ||
|
||
test('escapes quote (") with a backslash', () => { | ||
const str = 'a"b"c'; | ||
expect(escapeCqlWildcards(str)).toEqual('a\\"b\\"c'); | ||
}); | ||
|
||
test('escapes backslash (\\) with a backslash', () => { | ||
const str = 'a\\b\\c'; | ||
expect(escapeCqlWildcards(str)).toEqual('a\\\\b\\\\c'); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSDoc of escapeCqlWildcards and escapeCqlValue may refer to each other using
@see
and@link
.